From 5a8b699e2f0bcc253851d056e55c63080e5d2b1d Mon Sep 17 00:00:00 2001 From: Ivan Li Date: Fri, 7 May 2021 20:49:35 +0800 Subject: [PATCH] feat(pipelines): normalization name. --- src/pipelines/dtos/update-pipeline.input.ts | 4 +++- src/pipelines/pipelines.resolver.ts | 9 ++++----- src/pipelines/pipelines.service.ts | 6 +++--- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/pipelines/dtos/update-pipeline.input.ts b/src/pipelines/dtos/update-pipeline.input.ts index b64f8ba..6e9772f 100644 --- a/src/pipelines/dtos/update-pipeline.input.ts +++ b/src/pipelines/dtos/update-pipeline.input.ts @@ -2,4 +2,6 @@ import { InputType } from '@nestjs/graphql'; import { CreatePipelineInput } from './create-pipeline.input'; @InputType() -export class UpdatePipelineInput extends CreatePipelineInput {} +export class UpdatePipelineInput extends CreatePipelineInput { + id: string; +} diff --git a/src/pipelines/pipelines.resolver.ts b/src/pipelines/pipelines.resolver.ts index 572e612..4298fc2 100644 --- a/src/pipelines/pipelines.resolver.ts +++ b/src/pipelines/pipelines.resolver.ts @@ -9,12 +9,12 @@ import { ListPipelineArgs } from './dtos/list-pipelines.args'; export class PipelinesResolver { constructor(private readonly service: PipelinesService) {} @Query(() => [Pipeline]) - async listPipelines(@Args() dto: ListPipelineArgs) { + async pipelines(@Args() dto: ListPipelineArgs) { return await this.service.list(dto); } @Query(() => Pipeline) - async findPipeline(@Args('id', { type: () => String }) id: string) { + async pipeline(@Args('id', { type: () => String }) id: string) { return await this.service.findOne(id); } @@ -27,12 +27,11 @@ export class PipelinesResolver { } @Mutation(() => Pipeline) - async modifyPipeline( - @Args('id', { type: () => String }) id: string, + async updatePipeline( @Args('Pipeline', { type: () => UpdatePipelineInput }) dto: UpdatePipelineInput, ) { - const tmp = await this.service.update(id, dto); + const tmp = await this.service.update(dto); console.log(tmp); return tmp; } diff --git a/src/pipelines/pipelines.service.ts b/src/pipelines/pipelines.service.ts index 51eed17..4eabeae 100644 --- a/src/pipelines/pipelines.service.ts +++ b/src/pipelines/pipelines.service.ts @@ -31,9 +31,9 @@ export class PipelinesService extends BaseDbService { return await this.repository.save(this.repository.create(dto)); } - async update(id: string, dto: UpdatePipelineInput) { - await this.isDuplicateEntityForUpdate(id, dto); - const old = await this.findOne(id); + async update(dto: UpdatePipelineInput) { + await this.isDuplicateEntityForUpdate(dto.id, dto); + const old = await this.findOne(dto.id); return await this.repository.save(this.repository.merge(old, dto)); }