src/pipeline-tasks/pipeline-task.consumer.ts

@@ -1,11 +1,6 @@
 import { PipelineTaskLogs } from './models/pipeline-task-logs.model';
 import { ReposService } from './../repos/repos.service';
-import {
-  OnQueueCompleted,
-  OnQueueFailed,
-  Process,
-  Processor,
-} from '@nestjs/bull';
+import { OnQueueCompleted, Process, Processor } from '@nestjs/bull';
 import { Job } from 'bull';
 import { spawn } from 'child_process';
 import { PipelineTask } from './pipeline-task.entity';
@@ -126,9 +121,4 @@ export class PipelineTaskConsumer {
   onCompleted(job: Job<PipelineTask>) {
     this.service.doNextTask(job.data.pipeline);
   }
-
-  @OnQueueFailed()
-  onFailed(job: Job<PipelineTask>) {
-    this.service.doNextTask(job.data.pipeline);
-  }
 }

src/pipeline-tasks/pipeline-tasks.resolver.spec.ts

@@ -1,7 +1,6 @@
 import { Test, TestingModule } from '@nestjs/testing';
 import { PipelineTasksResolver } from './pipeline-tasks.resolver';
 import { PipelineTaskLogsService } from './pipeline-task-logs.service';
-import { PipelineTasksService } from './pipeline-tasks.service';
 
 describe('PipelineTasksResolver', () => {
   let resolver: PipelineTasksResolver;
@@ -10,10 +9,6 @@ describe('PipelineTasksResolver', () => {
     const module: TestingModule = await Test.createTestingModule({
       providers: [
         PipelineTasksResolver,
-        {
-          provide: PipelineTasksService,
-          useValue: {},
-        },
         {
           provide: PipelineTaskLogsService,
           useValue: {},

src/pipeline-tasks/pipeline-tasks.service.ts

@@ -1,7 +1,7 @@
-import { ConflictException, Injectable } from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import { PipelineTask } from './pipeline-task.entity';
-import { In, Repository } from 'typeorm';
+import { Repository } from 'typeorm';
 import { CreatePipelineTaskInput } from './dtos/create-pipeline-task.input';
 import { RedisService } from 'nestjs-redis';
 import { Pipeline } from '../pipelines/pipeline.entity';
@@ -10,8 +10,6 @@ import { PIPELINE_TASK_QUEUE } from './pipeline-tasks.constants';
 import { Queue } from 'bull';
 import { LockFailedException } from '../commons/exceptions/lock-failed.exception';
 import { PubSub } from 'apollo-server-express';
-import { TaskStatuses } from './enums/task-statuses.enum';
-import { isNil } from 'ramda';
 
 @Injectable()
 export class PipelineTasksService {
@@ -30,17 +28,6 @@ export class PipelineTasksService {
       where: { id: dto.pipelineId },
       relations: ['project'],
     });
-    // const hasUnfinishedTask = await this.repository
-    //   .findOne({
-    //     pipelineId: pipeline.id,
-    //     status: In([TaskStatuses.pending, TaskStatuses.working]),
-    //   })
-    //   .then((val) => !isNil(val));
-    // if (hasUnfinishedTask) {
-    //   throw new ConflictException(
-    //     'there are still unfinished task in the current pipeline.',
-    //   );
-    // }
     const task = await this.repository.save(this.repository.create(dto));
     task.pipeline = pipeline;