src/commons/exceptions/application.exception.ts

@@ -1,11 +1,11 @@
-import { pick } from 'ramda';
-
 export class ApplicationException extends Error {
   code: number;
   error: Error;
 
   constructor(
-    message: string | { error?: Error; message?: string | any; code?: number },
+    message:
+      | string
+      | { error?: Error; message?: string | object; code?: number },
   ) {
     if (message instanceof Object) {
       super();
@@ -18,8 +18,4 @@ export class ApplicationException extends Error {
       super((message as unknown) as any);
     }
   }
-
-  toJSON() {
-    return pick(['code', 'message'], this);
-  }
 }

src/commons/services/base-db.service.ts

@@ -53,22 +53,8 @@ export class BaseDbService<Entity extends AppBaseEntity> extends TypeormHelper {
   async isDuplicateEntityForUpdate<Dto extends Entity>(
     id: string,
     dto: Partial<Dto>,
-    extendsFields?: Array<keyof Dto & string>,
-  ): Promise<false | never>;
-  async isDuplicateEntityForUpdate<Dto extends Entity>(
-    old: Entity,
-    dto: Partial<Dto>,
-    extendsFields?: Array<keyof Dto & string>,
-  ): Promise<false | never>;
-  async isDuplicateEntityForUpdate<Dto extends Entity>(
-    id: string | Entity,
-    dto: Partial<Dto>,
     extendsFields: Array<keyof Dto & string> = [],
   ): Promise<false | never> {
-    if (typeof id !== 'string') {
-      dto = Object.assign({}, id, dto);
-      id = id.id;
-    }
     const qb = this.repository.createQueryBuilder('entity');
     const compareFields = this.getCompareFields(dto, [
       ...this.uniqueFields,

src/pipeline-tasks/models/work-unit-metadata.model.ts

@@ -1,10 +1,9 @@
-import { Field, InputType, Int, ObjectType } from '@nestjs/graphql';
+import { InputType, ObjectType } from '@nestjs/graphql';
 import { WorkUnit } from './work-unit.model';
 
 @InputType('WorkUnitMetadataInput')
 @ObjectType()
 export class WorkUnitMetadata {
-  @Field(() => Int)
   version = 1;
   units: WorkUnit[];
 }

src/pipeline-tasks/pipeline-tasks.service.ts

@@ -120,8 +120,6 @@ export class PipelineTasksService {
             };
 
             task.logs.push(l);
-          } else {
-            l.logs += event.message;
           }
 
           if (terminalTaskStatuses.includes(event.status)) {

src/pipelines/dtos/update-pipeline.input.ts

@@ -1,9 +1,7 @@
-import { InputType, OmitType } from '@nestjs/graphql';
+import { InputType } from '@nestjs/graphql';
 import { CreatePipelineInput } from './create-pipeline.input';
 
 @InputType()
-export class UpdatePipelineInput extends OmitType(CreatePipelineInput, [
-  'projectId',
-]) {
+export class UpdatePipelineInput extends CreatePipelineInput {
   id: string;
 }

src/pipelines/pipelines.resolver.ts

@@ -21,14 +21,14 @@ export class PipelinesResolver {
   @Mutation(() => Pipeline)
   async createPipeline(
     @Args('pipeline', { type: () => CreatePipelineInput })
-    dto: CreatePipelineInput,
+    dto: UpdatePipelineInput,
   ) {
     return await this.service.create(dto);
   }
 
   @Mutation(() => Pipeline)
   async updatePipeline(
-    @Args('pipeline', { type: () => UpdatePipelineInput })
+    @Args('Pipeline', { type: () => UpdatePipelineInput })
     dto: UpdatePipelineInput,
   ) {
     const tmp = await this.service.update(dto);

src/pipelines/pipelines.service.ts

@@ -14,8 +14,6 @@ import {
 import { AmqpConnection } from '@golevelup/nestjs-rabbitmq';
 import { Commit } from '../repos/dtos/log-list.model';
 import { getAppInstanceRouteKey } from '../commons/utils/rabbit-mq';
-import { ApplicationException } from '../commons/exceptions/application.exception';
-import { plainToClass } from 'class-transformer';
 
 @Injectable()
 export class PipelinesService extends BaseDbService<Pipeline> {
@@ -44,8 +42,8 @@ export class PipelinesService extends BaseDbService<Pipeline> {
   }
 
   async update(dto: UpdatePipelineInput) {
+    await this.isDuplicateEntityForUpdate(dto.id, dto);
     const old = await this.findOne(dto.id);
-    await this.isDuplicateEntityForUpdate(old, dto);
     return await this.repository.save(this.repository.merge(old, dto));
   }
 
@@ -62,17 +60,17 @@ export class PipelinesService extends BaseDbService<Pipeline> {
   }
   async listCommits(pipeline: Pipeline) {
     return await this.amqpConnection
-      .request<[Error, Commit[]]>({
+      .request<Commit[]>({
         exchange: EXCHANGE_REPO,
         routingKey: ROUTE_LIST_COMMITS,
         payload: pipeline,
-        timeout: 30_000,
+        timeout: 10_000,
       })
-      .then(([error, list]) => {
-        if (error) {
-          throw new ApplicationException(error);
-        }
-        return plainToClass(Commit, list);
-      });
+      .then((list) =>
+        list.map((item) => {
+          item.date = new Date(item.date);
+          return item;
+        }),
+      );
   }
 }

src/repos/dtos/log-list.model.ts

@@ -1,12 +1,10 @@
 import { ObjectType, Field } from '@nestjs/graphql';
-import { Type } from 'class-transformer';
 import { LogResult, DefaultLogFields } from 'simple-git';
 import { PipelineTask } from '../../pipeline-tasks/pipeline-task.entity';
 
 @ObjectType()
 export class Commit {
   hash: string;
-  @Type(() => Date)
   date: Date;
   message: string;
   refs: string;

src/repos/repos.service.ts

@@ -26,7 +26,6 @@ import {
   getInstanceName,
   getSelfInstanceRouteKey,
 } from '../commons/utils/rabbit-mq';
-import { ApplicationException } from '../commons/exceptions/application.exception';
 
 const DEFAULT_REMOTE_NAME = 'origin';
 const INFO_PATH = '@info';
@@ -130,7 +129,7 @@ export class ReposService {
       autoDelete: true,
     },
   })
-  async listCommits(pipeline: Pipeline): Promise<[Error, Commit[]?]> {
+  async listCommits(pipeline: Pipeline): Promise<Commit[] | Nack> {
     const git = await this.getGit(pipeline.project, undefined, {
       fetch: false,
     });
@@ -141,23 +140,20 @@ export class ReposService {
         `remotes/origin/${pipeline.branch}`,
         '--',
       ]);
-      return [
-        null,
-        data.all.map(
+      return data.all.map(
         (it) =>
           ({
             ...it,
             date: new Date(it.date),
           } as Commit),
-        ),
-      ];
+      );
     } catch (error) {
       this.logger.error(
         { error, pipeline },
         '[listCommits] %s',
         error?.message,
       );
-      return [new ApplicationException(error)];
+      return new Nack();
     }
   }