Ivan/commento
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

smtp_configure_test.go: clean env before test

Browse Source 
Sometimes the tests end before they reach the end.
This commit is contained in:
Adhityaa 2018-06-13 00:32:32 +05:30
parent a3a6f2ba68
commit 425312034f
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
api/smtp_configure_test.go
View File

@ -13,6 +13,7 @@ func cleanSmtpVars() {
func TestSmtpConfigureBasics(t *testing.T) { func TestSmtpConfigureBasics(t *testing.T) {
failTestOnError(t, setupTestEnv()) failTestOnError(t, setupTestEnv())
cleanSmtpVars()
os.Setenv("SMTP_USERNAME", "test@example.com") os.Setenv("SMTP_USERNAME", "test@example.com")
os.Setenv("SMTP_PASSWORD", "hunter2") os.Setenv("SMTP_PASSWORD", "hunter2")
@ -23,12 +24,11 @@ func TestSmtpConfigureBasics(t *testing.T) {
t.Errorf("unexpected error when configuring SMTP: %v", err) t.Errorf("unexpected error when configuring SMTP: %v", err)
return return
} }
cleanSmtpVars()
} }
func TestSmtpConfigureEmptyHost(t *testing.T) { func TestSmtpConfigureEmptyHost(t *testing.T) {
failTestOnError(t, setupTestEnv()) failTestOnError(t, setupTestEnv())
cleanSmtpVars()
os.Setenv("SMTP_USERNAME", "test@example.com") os.Setenv("SMTP_USERNAME", "test@example.com")
os.Setenv("SMTP_PASSWORD", "hunter2") os.Setenv("SMTP_PASSWORD", "hunter2")
@ -43,12 +43,11 @@ func TestSmtpConfigureEmptyHost(t *testing.T) {
t.Errorf("SMTP configured when it should not be due to empty COMMENTO_SMTP_HOST") t.Errorf("SMTP configured when it should not be due to empty COMMENTO_SMTP_HOST")
return return
} }
cleanSmtpVars()
} }
func TestSmtpConfigureEmptyAddress(t *testing.T) { func TestSmtpConfigureEmptyAddress(t *testing.T) {
failTestOnError(t, setupTestEnv()) failTestOnError(t, setupTestEnv())
cleanSmtpVars()
os.Setenv("SMTP_USERNAME", "test@example.com") os.Setenv("SMTP_USERNAME", "test@example.com")
os.Setenv("SMTP_PASSWORD", "hunter2") os.Setenv("SMTP_PASSWORD", "hunter2")
@ -59,6 +58,4 @@ func TestSmtpConfigureEmptyAddress(t *testing.T) {
t.Errorf("expected error not found; SMTP should not be configured when COMMENTO_SMTP_FROM_ADDRESS is empty") t.Errorf("expected error not found; SMTP should not be configured when COMMENTO_SMTP_FROM_ADDRESS is empty")
return return
} }
cleanSmtpVars()
} }