From 982a5745125c5fc948ed03652be184d763c2312e Mon Sep 17 00:00:00 2001 From: Adhityaa Chandrasekar Date: Wed, 21 Aug 2019 21:14:19 -0700 Subject: [PATCH] email_notification_new.go: do not return on pageTitleUpdate errors --- api/email_notification_new.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/api/email_notification_new.go b/api/email_notification_new.go index 2ace972..fa0ffed 100644 --- a/api/email_notification_new.go +++ b/api/email_notification_new.go @@ -128,8 +128,9 @@ func emailNotificationNew(d domain, path string, commenterHex string, commentHex if p.Title == "" { p.Title, err = pageTitleUpdate(d.Domain, path) if err != nil { - logger.Errorf("cannot update/get page title to send email notification: %v", err) - return + // Not being able to update a page title isn't serious enough to skip an + // email notification. + p.Title = d.Domain } }